Use the PolySharp package for polyfills #1364
Draft
+22
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PolySharp][1] provides generated, source-only polyfills for C# language features, to easily use all runtime-agnostic features downlevel. This replaces the need for the `Nullable` package and we can get rid of the manually added `IsExternalInit` polyfill. Also, while I was touching the csproj and props file I standardised the way to import dev dependencies with the PrivateAssets="all" attribute. [1]: https://github.com/Sergio0694/PolySharp/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolySharp provides generated, source-only polyfills for C# language features, to easily use all runtime-agnostic features downlevel.
This replaces the need for the
Nullablepackage and we can get rid of the manually addedIsExternalInitpolyfill.Also, while I was touching the csproj and props file I standardised the way to import dev dependencies with the PrivateAssets="all" attribute.
I'm opening this as a draft pull request because I'm waiting for Sergio to answer Sergio0694/PolySharp#90.
Please upvote 👍 this pull request if you are interested in it.